In Add users to group, only the first 10 can be viewed or selected #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2130 +/- ##
====================================================
- Coverage 35.11% 35.02% -0.09%
- Complexity 1418 1419 +1
====================================================
Files 535 537 +2
Lines 16187 16248 +61
Branches 1037 1041 +4
====================================================
+ Hits 5684 5691 +7
- Misses 10209 10263 +54
Partials 294 294 ☔ View full report in Codecov by Sentry. |
heditar
approved these changes
Jan 3, 2025
| .admin(tuple.get("user_admin", boolean.class)) | ||
| .organizationName(tuple.get("user_organization_name", String.class)) | ||
| .tags( | ||
| Arrays.stream(tuple.get("user_tags", String[].class)) |
There was a problem hiding this comment.
nit: I think you can just do Set.of(...)
There was a problem hiding this comment.
Good shot
It's fixed
| public static List<UserOutput> execution(TypedQuery<Tuple> query) { | ||
| return query.getResultList().stream() | ||
| .map( | ||
| tuple -> |
There was a problem hiding this comment.
As we discussed I think we should avoid that (DB to DTO) but it's not blocking as we need to discuss it as a team
There was a problem hiding this comment.
Yes, I code it before our discussion...
We need to talk about it, I will add it to our internal notion
RomuDeuxfois
force-pushed
the
issue/2077
branch
from
25a0e63 to
1470ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...