Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Change "Add teams..." dialog into "Modify teams..." and alter behaviour (#2112) #2127

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Dec 26, 2024

Proposed changes

  • "Add teams..." controls in Inject definitions is changed to "Modify teams"
  • The Modify teams dialog allows for adding or removing teams to/from inject
  • Allowed team list is scoped down to the teams added to a scenario/simulation accordingly
    • If no teams were added to a scenario or simulation, no teams are available to add to injects

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Based on @antoinemzs work

antoinemzs and others added 4 commits December 26, 2024 17:30
@RomuDeuxfois RomuDeuxfois marked this pull request as draft December 26, 2024 17:19
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.12%. Comparing base (43019c7) to head (1e673dc).
Report is 3 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...src/main/java/io/openbas/utils/InjectionUtils.java 0.00% 4 Missing ⚠️
...va/io/openbas/rest/asset/endpoint/EndpointApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.11.0    #2127   +/-   ##
=================================================
  Coverage             35.11%   35.12%           
  Complexity             1418     1418           
=================================================
  Files                   535      536    +1     
  Lines                 16187    16184    -3     
  Branches               1037     1036    -1     
=================================================
  Hits                   5684     5684           
+ Misses                10209    10206    -3     
  Partials                294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review December 27, 2024 07:57
@RomuDeuxfois RomuDeuxfois marked this pull request as draft December 27, 2024 07:57
@RomuDeuxfois RomuDeuxfois linked an issue Dec 27, 2024 that may be closed by this pull request
@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review December 27, 2024 08:57
@antoinemzs
Copy link
Contributor

The scope looks to have increased from the issue's description, just to be clear, this solves the issue and introduces a similar behaviour for Target Assets ?

@RomuDeuxfois
Copy link
Member Author

The scope looks to have increased from the issue's description, just to be clear, this solves the issue and introduces a similar behaviour for Target Assets ?

Exactly, I realized that we also had to align the behavior with assets and asset groups in order to have something consistent for the user.

@damgouj damgouj self-requested a review December 30, 2024 15:43
@RomuDeuxfois RomuDeuxfois merged commit 35755b2 into release/1.11.0 Dec 31, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/2112 branch December 31, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying targets in an inject is not working properly
3 participants