-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Change "Add teams..." dialog into "Modify teams..." and alter behaviour (#2112) #2127
Conversation
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
2898ff7
to
daf016c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2127 +/- ##
=================================================
Coverage 35.11% 35.12%
Complexity 1418 1418
=================================================
Files 535 536 +1
Lines 16187 16184 -3
Branches 1037 1036 -1
=================================================
Hits 5684 5684
+ Misses 10209 10206 -3
Partials 294 294 ☔ View full report in Codecov by Sentry. |
The scope looks to have increased from the issue's description, just to be clear, this solves the issue and introduces a similar behaviour for Target Assets ? |
Exactly, I realized that we also had to align the behavior with assets and asset groups in order to have something consistent for the user. |
Proposed changes
Related issues
Checklist
Further comments
Based on @antoinemzs work