Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Apply the right platform & architecture when generating a scenario from OCTI (#1713) #2003

Merged
merged 19 commits into from
Dec 12, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Dec 6, 2024

Proposed changes

  • Add non-regression tests for endpoints used by the Octi feature
  • Sync values for architectures

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 changed the base branch from master to release/1.10.0 December 6, 2024 09:39
@savacano28 savacano28 self-assigned this Dec 6, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.46%. Comparing base (59832b4) to head (43dc5d3).
Report is 1 commits behind head on release/1.10.0.

Files with missing lines Patch % Lines
...java/io/openbas/utils/ArchitectureFilterUtils.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.10.0    #2003      +/-   ##
====================================================
+ Coverage             34.44%   34.46%   +0.01%     
  Complexity             1332     1332              
====================================================
  Files                   524      525       +1     
  Lines                 15823    15826       +3     
  Branches                998      998              
====================================================
+ Hits                   5451     5455       +4     
+ Misses                10102    10101       -1     
  Partials                270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review December 11, 2024 08:43
@RomuDeuxfois RomuDeuxfois self-requested a review December 11, 2024 12:29
@RomuDeuxfois
Copy link
Member

Tested 🆗

@savacano28 savacano28 merged commit 321a6ca into release/1.10.0 Dec 12, 2024
6 checks passed
@savacano28 savacano28 deleted the issue/1713 branch December 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply the right platform & architecture when generating a scenario from OCTI 
2 participants