Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Refactor creation of inject expectations #1986

Merged
merged 24 commits into from
Dec 5, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Dec 3, 2024

Proposed changes

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Dec 3, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Dec 3, 2024
@savacano28 savacano28 force-pushed the bugfix/refact-injectExpectations-1 branch from c73fcb2 to 38c9651 Compare December 3, 2024 18:04
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 33.56%. Comparing base (80194de) to head (12e664f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 4 Missing ⚠️
...openbas/injectors/challenge/ChallengeExecutor.java 25.00% 3 Missing ⚠️
.../io/openbas/injectors/channel/ChannelExecutor.java 25.00% 3 Missing ⚠️
.../java/io/openbas/injectors/ovh/OvhSmsExecutor.java 0.00% 3 Missing ⚠️
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 2 Missing ⚠️
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 2 Missing ⚠️
.../io/openbas/injectors/opencti/OpenCTIExecutor.java 33.33% 2 Missing ⚠️
...n/java/io/openbas/injectors/lade/LadeExecutor.java 0.00% 1 Missing ⚠️
...o/openbas/injectors/mastodon/MastodonExecutor.java 0.00% 1 Missing ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1986      +/-   ##
============================================
- Coverage     33.62%   33.56%   -0.07%     
+ Complexity     1671     1665       -6     
============================================
  Files           572      572              
  Lines         16697    16695       -2     
  Branches        970      970              
============================================
- Hits           5614     5603      -11     
- Misses        10829    10838       +9     
  Partials        254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the bugfix/refact-injectExpectations-1 branch from f19969e to 4ec47d4 Compare December 4, 2024 07:41
@savacano28 savacano28 marked this pull request as ready for review December 4, 2024 07:41
@MarineLeM MarineLeM self-requested a review December 5, 2024 10:56
@savacano28 savacano28 merged commit df1ff7a into master Dec 5, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/refact-injectExpectations-1 branch December 12, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants