Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Adding a new "health" endpoint (#1850) #1950

Merged
merged 20 commits into from
Dec 4, 2024
Merged

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Nov 28, 2024

Proposed changes

  • Adding a new "health" endpoint that will return 200 if the service is healthy otherwise 5xx

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@heditar heditar added the filigran team use to identify PR from the Filigran team label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Project coverage is 34.16%. Comparing base (756dd1e) to head (3bc5843).
Report is 1 commits behind head on release/1.10.0.

Files with missing lines Patch % Lines
...in/java/io/openbas/service/HealthCheckService.java 57.57% 14 Missing ⚠️
...a/io/openbas/rest/health_check/HealthCheckApi.java 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.10.0    #1950      +/-   ##
====================================================
+ Coverage             34.03%   34.16%   +0.12%     
- Complexity             1303     1315      +12     
====================================================
  Files                   519      522       +3     
  Lines                 15661    15716      +55     
  Branches                972      975       +3     
====================================================
+ Hits                   5330     5369      +39     
- Misses                10070    10084      +14     
- Partials                261      263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heditar heditar changed the base branch from master to release/1.10.0 November 29, 2024 12:59
Copy link
Contributor

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nitpicks but solid work overall, thanks!

@heditar heditar requested a review from antoinemzs December 4, 2024 07:45
@heditar heditar requested a review from antoinemzs December 4, 2024 14:10
@heditar heditar merged commit 8b7f64d into release/1.10.0 Dec 4, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/1850 branch January 6, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce /health endpoint
2 participants