Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Delete notblank annotation #1931

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

savacano28
Copy link
Contributor

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Nov 27, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 27, 2024
@savacano28 savacano28 marked this pull request as ready for review November 27, 2024 08:10
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.76%. Comparing base (f9b0e5b) to head (98d1a0a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1931      +/-   ##
============================================
- Coverage     33.80%   33.76%   -0.05%     
- Complexity     1686     1687       +1     
============================================
  Files           572      572              
  Lines         16679    16702      +23     
  Branches        968      972       +4     
============================================
+ Hits           5638     5639       +1     
- Misses        10786    10808      +22     
  Partials        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 6943cc3 into master Nov 27, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/notblank-field-scenario branch November 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants