Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Display teams on quick inject #1925

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Nov 26, 2024

Fix:

  • Throw error on SMS executor when number is invalid
  • Display teams on quick inject
  • Add padding on simulation overview

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.72%. Comparing base (1954e77) to head (72a04d8).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../java/io/openbas/injectors/ovh/OvhSmsExecutor.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1925      +/-   ##
============================================
- Coverage     33.75%   33.72%   -0.04%     
  Complexity     1684     1684              
============================================
  Files           572      572              
  Lines         16683    16701      +18     
  Branches        968      969       +1     
============================================
  Hits           5632     5632              
- Misses        10796    10814      +18     
  Partials        255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review November 26, 2024 15:35
@RomuDeuxfois RomuDeuxfois merged commit 6aa34fa into master Nov 26, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the bugfix/release-1.9-2 branch November 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants