-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Fix NoSuchBeanDefinitionException in retrieving command line #1902
Conversation
context.getBean( | ||
injectorContract.getInjector().getType(), io.openbas.execution.Injector.class); | ||
return executor.getCommandsLines(injectorContract.getId()); | ||
} catch (NoSuchBeanDefinitionException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: You should log here that we are swallowing the exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I add some details.
Is this consistent with the idea you had?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably escalate to Warning I suppose, it looks like a misconfiguration if the requested class is not available for loading.
Otherwise yes it's what I am referring to: no silently dropping an exception, so that we at least know from the logs that something is happening
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1902 +/- ##
============================================
- Coverage 33.61% 33.61% -0.01%
- Complexity 1682 1683 +1
============================================
Files 573 573
Lines 16748 16753 +5
Branches 976 976
============================================
+ Hits 5630 5631 +1
- Misses 10863 10867 +4
Partials 255 255 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
a081b03
to
317909d
Compare
#1903