Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Delete actions are not allowed on the injectresult list #1884

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Nov 18, 2024

Proposed changes

image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 marked this pull request as ready for review November 18, 2024 11:57
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.04%. Comparing base (d20c8e3) to head (29ee24b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1884   +/-   ##
=========================================
  Coverage     33.04%   33.04%           
  Complexity     1653     1653           
=========================================
  Files           571      571           
  Lines         16766    16766           
  Branches        971      971           
=========================================
  Hits           5540     5540           
  Misses        10979    10979           
  Partials        247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@savacano28 savacano28 self-assigned this Nov 18, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 18, 2024
@savacano28 savacano28 merged commit 94a6840 into master Nov 19, 2024
7 checks passed
@antoinemzs antoinemzs deleted the bugfix/1862 branch November 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions are not allowed on the Inject Results list in the Exercise Overview
2 participants