Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix raw teams request (#1704) #1721

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[backend] Fix raw teams request (#1704) #1721

merged 3 commits into from
Oct 23, 2024

Conversation

guillaumejparis
Copy link
Member

Close #1704

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 21.47651% with 117 lines in your changes missing coverage. Please review.

Project coverage is 33.40%. Comparing base (55d481f) to head (e9bed44).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...pi/src/main/java/io/openbas/rest/team/TeamApi.java 1.38% 71 Missing ⚠️
...c/main/java/io/openbas/rest/helper/TeamHelper.java 40.25% 45 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1721      +/-   ##
============================================
- Coverage     33.52%   33.40%   -0.13%     
+ Complexity     1608     1597      -11     
============================================
  Files           557      557              
  Lines         14477    14467      -10     
  Branches        871      873       +2     
============================================
- Hits           4854     4832      -22     
- Misses         9398     9410      +12     
  Partials        225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 changed the title [backend] fix raw teams request (#1704) [backend] Fix raw teams request (#1704) Oct 22, 2024
@RomuDeuxfois
Copy link
Member

Seems good on code side, need to be tests

@RomuDeuxfois RomuDeuxfois self-requested a review October 23, 2024 06:40
@guillaumejparis guillaumejparis merged commit ca7d52e into master Oct 23, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/1704 branch October 23, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message "internal error" + Error 500 occurring when creating a technical scenario
3 participants