Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix Mitre Att&ck Coverage display on Firefox #1484

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

isselparra
Copy link
Contributor

@isselparra isselparra commented Sep 19, 2024

Close #1435

Proposed changes

  • Remove experimental attributes since non compatible with Firefox

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality

Before (Firefox):
Screenshot from 2024-09-19 16-51-11

After (Firefox):
Screenshot from 2024-09-19 16-51-41

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.55%. Comparing base (c04a750) to head (ab320fa).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1484   +/-   ##
=========================================
  Coverage     32.55%   32.55%           
  Complexity     1464     1464           
=========================================
  Files           534      534           
  Lines         13766    13766           
  Branches        824      824           
=========================================
  Hits           4482     4482           
  Misses         9075     9075           
  Partials        209      209           
Flag Coverage Δ
32.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra self-assigned this Sep 19, 2024
@isselparra isselparra changed the title [frontent] Remove experimental css attributes [frontent] FIx Mitre Att&ck Coverage display on Firefox Sep 20, 2024
@isselparra isselparra changed the title [frontent] FIx Mitre Att&ck Coverage display on Firefox [frontent] Fix Mitre Att&ck Coverage display on Firefox Sep 20, 2024
@isselparra isselparra changed the title [frontent] Fix Mitre Att&ck Coverage display on Firefox [frontend] Fix Mitre Att&ck Coverage display on Firefox Sep 20, 2024
@isselparra isselparra force-pushed the issue/1435 branch 2 times, most recently from fb064c7 to 46d10af Compare September 20, 2024 15:42
@isselparra isselparra force-pushed the issue/1435 branch 2 times, most recently from 5c5d9f6 to 52a9619 Compare September 20, 2024 15:55
@isselparra isselparra merged commit 243bf8c into master Sep 20, 2024
8 checks passed
@isselparra isselparra deleted the issue/1435 branch September 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mitre Attack Coverage is partially hidden on firefox
2 participants