Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] fix trigger now injects #1424

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[backend/frontend] fix trigger now injects #1424

merged 5 commits into from
Sep 18, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 13, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Sep 13, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.41%. Comparing base (5d61515) to head (ac51fe1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/rest/inject/InjectApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1424      +/-   ##
============================================
+ Coverage     31.38%   31.41%   +0.02%     
- Complexity     1404     1406       +2     
============================================
  Files           528      528              
  Lines         13707    13708       +1     
  Branches        814      814              
============================================
+ Hits           4302     4306       +4     
+ Misses         9205     9202       -3     
  Partials        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM MarineLeM marked this pull request as ready for review September 16, 2024 15:16
@MarineLeM MarineLeM linked an issue Sep 16, 2024 that may be closed by this pull request
@guillaumejparis guillaumejparis self-requested a review September 17, 2024 06:52
@MarineLeM MarineLeM linked an issue Sep 17, 2024 that may be closed by this pull request
@guillaumejparis
Copy link
Member

@RomuDeuxfois this pr seems to fix an old bug of us the #265, seems right for you ?

@MarineLeM MarineLeM merged commit d136ac6 into master Sep 18, 2024
8 checks passed
@MarineLeM MarineLeM deleted the bugfix/1395 branch September 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause on simulation delay trigger now action Triggering the inject now change the date of the inject
3 participants