-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] duplicate XLS mapper (#1250) #1354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
============================================
+ Coverage 29.22% 29.29% +0.07%
- Complexity 1322 1327 +5
============================================
Files 523 523
Lines 13504 13530 +26
Branches 801 803 +2
============================================
+ Hits 3946 3964 +18
- Misses 9378 9385 +7
- Partials 180 181 +1 ☔ View full report in Codecov by Sentry. |
savacano28
reviewed
Aug 28, 2024
savacano28
reviewed
Aug 28, 2024
openbas-api/src/main/java/io/openbas/utils/CopyObjectListUtils.java
Outdated
Show resolved
Hide resolved
savacano28
approved these changes
Aug 28, 2024
Test 🆗 |
Dimfacion
reviewed
Aug 28, 2024
Dimfacion
reviewed
Aug 28, 2024
Dimfacion
reviewed
Aug 28, 2024
openbas-front/src/admin/components/settings/data_ingestion/XlsMapperPopover.tsx
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Aug 28, 2024
openbas-api/src/main/java/io/openbas/utils/CopyObjectListUtils.java
Outdated
Show resolved
Hide resolved
Dimfacion
reviewed
Aug 28, 2024
RomuDeuxfois
approved these changes
Aug 29, 2024
Dimfacion
approved these changes
Aug 29, 2024
9c4b54b
to
491b5c1
Compare
491b5c1
to
6a711a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate XLS mapper