Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] duplicate XLS mapper (#1250) #1354

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

MarineLeM
Copy link
Contributor

Duplicate XLS mapper

@MarineLeM MarineLeM added the filigran team use to identify PR from the Filigran team label Aug 28, 2024
@MarineLeM MarineLeM linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.29%. Comparing base (07a544e) to head (6a711a7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/openbas/utils/CopyObjectListUtils.java 86.36% 3 Missing ⚠️
...rc/main/java/io/openbas/service/MapperService.java 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1354      +/-   ##
============================================
+ Coverage     29.22%   29.29%   +0.07%     
- Complexity     1322     1327       +5     
============================================
  Files           523      523              
  Lines         13504    13530      +26     
  Branches        801      803       +2     
============================================
+ Hits           3946     3964      +18     
- Misses         9378     9385       +7     
- Partials        180      181       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 self-requested a review August 28, 2024 14:37
@RomuDeuxfois
Copy link
Member

Test 🆗

@MarineLeM MarineLeM force-pushed the issue/1250-duplicate-XLS-mapper branch 3 times, most recently from 9c4b54b to 491b5c1 Compare August 29, 2024 08:37
@MarineLeM MarineLeM force-pushed the issue/1250-duplicate-XLS-mapper branch from 491b5c1 to 6a711a7 Compare August 29, 2024 08:46
@MarineLeM MarineLeM merged commit 6f42b4d into master Aug 29, 2024
6 checks passed
@MarineLeM MarineLeM deleted the issue/1250-duplicate-XLS-mapper branch August 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate an XLS mapper
4 participants