Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix contextual team while duplicating scenario #1303 #1343

Merged

Conversation

MarineLeM
Copy link
Contributor

  • Create new contextual team while duplicating scenario

@MarineLeM MarineLeM added the filigran team use to identify PR from the Filigran team label Aug 23, 2024
@MarineLeM MarineLeM assigned MarineLeM and unassigned MarineLeM Aug 23, 2024
@MarineLeM MarineLeM linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 29.06%. Comparing base (d6632c9) to head (dbb9e17).
Report is 1 commits behind head on master.

Files Patch % Lines
...java/io/openbas/rest/exercise/ExerciseService.java 65.21% 8 Missing ⚠️
...ain/java/io/openbas/utils/CopyObjectListUtils.java 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1343      +/-   ##
============================================
+ Coverage     27.98%   29.06%   +1.07%     
- Complexity     1282     1308      +26     
============================================
  Files           520      522       +2     
  Lines         13341    13383      +42     
  Branches        784      784              
============================================
+ Hits           3734     3890     +156     
+ Misses         9445     9327     -118     
- Partials        162      166       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


public class CopyObjectListUtils {

public static <T extends Base> List<T> copy(@NotNull final List<T> origins, Class<T> clazz) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

});
}

private Team createTeam(@NotBlank String name, Boolean isContextualTeam){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this in TeamFixture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes my bad i saw the utils/fixtures folder only this morning i will correct that

@RomuDeuxfois
Copy link
Member

Test OK for Scenario.
We have the bug in Simulation, it would be great to fix it in this PR too.

@MarineLeM MarineLeM merged commit 841acd0 into master Aug 27, 2024
6 checks passed
@MarineLeM MarineLeM deleted the issue/1303-fix-contextual-team-while-duplicating-scenario branch August 27, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contextual group still linked after scenario duplication
2 participants