Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add filters on payloads #1341

Merged
merged 5 commits into from
Aug 27, 2024
Merged

[backend/frontend] Add filters on payloads #1341

merged 5 commits into from
Aug 27, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Aug 22, 2024

Proposed changes

  • Add filters on payload list ONLY

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.52%. Comparing base (d6632c9) to head (d35e4d3).
Report is 2 commits behind head on master.

Files Patch % Lines
.../openbas/rest/attack_pattern/AttackPatternApi.java 0.00% 8 Missing ⚠️
...ava/io/openbas/schema/model/PropertySchemaDTO.java 0.00% 2 Missing ⚠️
.../openbas/rest/payload/form/PayloadCreateInput.java 0.00% 1 Missing ⚠️
.../openbas/rest/payload/form/PayloadUpdateInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1341      +/-   ##
============================================
+ Coverage     27.98%   28.52%   +0.54%     
- Complexity     1282     1299      +17     
============================================
  Files           520      520              
  Lines         13341    13351      +10     
  Branches        784      784              
============================================
+ Hits           3734     3809      +75     
+ Misses         9445     9372      -73     
- Partials        162      170       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Aug 22, 2024
@johanah29
Copy link
Member

There is an issue when trying to create an attack pattern while creating a payload.
image

@RomuDeuxfois
Copy link
Member Author

There is an issue when trying to create an attack pattern while creating a payload. image

Good point.
I fixed it, but in order for it to be clean we would have to migrate AttackPatternForm to the new standards.
We'll save that for later.

@RomuDeuxfois RomuDeuxfois marked this pull request as draft August 23, 2024 16:22
@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review August 26, 2024 09:25
@RomuDeuxfois
Copy link
Member Author

PR Ready for a second round:

  • Add quick filters on payloads -> Platform & Attack pattern
  • Add filters on payloads -> Name, description, source, status, tags, updated

@RomuDeuxfois RomuDeuxfois merged commit 0bca3fc into master Aug 27, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1294 branch August 27, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants