Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add info message of starting date mandatory on scenario #1319

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

savacano28
Copy link
Contributor

…port

Proposed changes

  • Add message info
  • Modify file name of mapper exports

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 requested a review from johanah29 August 12, 2024 08:39
@savacano28 savacano28 self-assigned this Aug 12, 2024
@savacano28 savacano28 changed the title [frontend] add info message of starting date mandatory on scenario im… [frontend] Add info message of starting date mandatory on scenario Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.02%. Comparing base (b597647) to head (6c32646).

Files Patch % Lines
...rc/main/java/io/openbas/rest/mapper/MapperApi.java 0.00% 4 Missing ⚠️
...io/openbas/rest/mapper/form/ExportMapperInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1319      +/-   ##
============================================
- Coverage     28.02%   28.02%   -0.01%     
  Complexity     1273     1273              
============================================
  Files           513      513              
  Lines         13269    13272       +3     
  Branches        779      780       +1     
============================================
  Hits           3719     3719              
- Misses         9387     9390       +3     
  Partials        163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review August 12, 2024 09:01
@savacano28 savacano28 merged commit afc5d47 into master Aug 12, 2024
6 checks passed
krish9797 added a commit to krish9797/openbas that referenced this pull request Aug 23, 2024
@savacano28 savacano28 deleted the issue/mapper-filename-message branch August 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants