Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend|Backend]Be able to troubleshoot a failed email/sms inject test #1311

Merged
merged 22 commits into from
Aug 19, 2024
Merged

[Frontend|Backend]Be able to troubleshoot a failed email/sms inject test #1311

merged 22 commits into from
Aug 19, 2024

Conversation

johanah29
Copy link
Member

No description provided.

@johanah29 johanah29 force-pushed the issue/1295 branch 3 times, most recently from 7f72d5c to 8cc9edf Compare August 9, 2024 10:29
@johanah29 johanah29 force-pushed the issue/1295 branch 2 times, most recently from 829d8a5 to b1d22da Compare August 14, 2024 13:21
@johanah29 johanah29 marked this pull request as ready for review August 14, 2024 13:21
@johanah29 johanah29 requested a review from savacano28 August 14, 2024 13:21
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (a1b7c10) to head (38e8904).
Report is 1 commits behind head on master.

Files Patch % Lines
...va/io/openbas/service/InjectTestStatusService.java 16.00% 21 Missing ⚠️
...s/rest/inject_test_status/InjectTestStatusApi.java 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1311      +/-   ##
============================================
+ Coverage     28.02%   28.27%   +0.25%     
- Complexity     1273     1282       +9     
============================================
  Files           513      516       +3     
  Lines         13272    13295      +23     
  Branches        780      780              
============================================
+ Hits           3719     3759      +40     
+ Misses         9390     9373      -17     
  Partials        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Aug 16, 2024
@johanah29 johanah29 merged commit 26709d2 into master Aug 19, 2024
6 checks passed
@johanah29 johanah29 deleted the issue/1295 branch August 19, 2024 10:01
@SamuelHassine SamuelHassine removed this from the Release 1.5.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimfacion Dimfacion Dimfacion left review comments

@savacano28 savacano28 savacano28 approved these changes

Assignees

@johanah29 johanah29

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johanah29 @savacano28 @Dimfacion @SamuelHassine