Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test inject in scenario and simulations #1267

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

johanah29
Copy link
Member

#1106 MVP 1,2 and 3

@johanah29 johanah29 self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 225 lines in your changes missing coverage. Please review.

Project coverage is 28.76%. Comparing base (8c9078c) to head (cadd9f8).

Files Patch % Lines
...rc/main/java/io/openbas/rest/inject/InjectApi.java 21.12% 218 Missing and 6 partials ⚠️
...va/io/openbas/rest/inject/output/InjectOutput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1267      +/-   ##
============================================
- Coverage     28.80%   28.76%   -0.04%     
- Complexity     1287     1288       +1     
============================================
  Files           507      507              
  Lines         13023    13056      +33     
  Branches        741      747       +6     
============================================
+ Hits           3751     3756       +5     
- Misses         9114     9141      +27     
- Partials        158      159       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 requested a review from savacano28 July 31, 2024 10:44
@RomuDeuxfois
Copy link
Member

I can test an inject when there are no content
It should not be possible

image

@johanah29
Copy link
Member Author

image
"Test" option is now disabled when no team is set.

@johanah29 johanah29 requested a review from RomuDeuxfois August 1, 2024 11:25
@RomuDeuxfois
Copy link
Member

One last thing:
one we click on test, the popover should close
image

@johanah29
Copy link
Member Author

image

@johanah29 johanah29 merged commit 279325d into master Aug 1, 2024
6 checks passed
@johanah29 johanah29 deleted the issue/1106 branch August 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants