[frontend] Add chinese language option #1266
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
============================================
+ Coverage 28.03% 28.27% +0.24%
- Complexity 1278 1282 +4
============================================
Files 516 516
Lines 13295 13295
Branches 780 780
============================================
+ Hits 3727 3759 +32
+ Misses 9405 9373 -32
Partials 163 163 ☔ View full report in Codecov by Sentry. |
| 'Selected payload': 'Charge utile sélectionnée', | ||
| Prevention: 'Prévention', | ||
| 'Start date should be at least today': 'La date de début doit être au moins aujourd\'hui', | ||
| 'Update the xls mapper': 'Mettre à jour le mapper XLS', |
There was a problem hiding this comment.
It hurts me to say this but it looks like the french word for "mapper" is "mappeur".
| @@ -96,6 +96,9 @@ const UserForm = ({ onSubmit, initialValues }) => { | |||
| <MenuItem key="fr" value="fr"> | |||
| {t('French')} | |||
| </MenuItem> | |||
| <MenuItem key="zh" value="zh"> | |||
| {t('Chinese')} | |||
There was a problem hiding this comment.
The translation is added on the profile but shouldn't we add it to the list of default languages of the platform too ?
There was a problem hiding this comment.
I am not sure to understand your point
It's already available in the AppIntlProvider class
There was a problem hiding this comment.
Oh, I missed the BrownserLanguage and the moment configuration
RomuDeuxfois
force-pushed
the
improvment/i18n-chinese
branch
from
195aeb8 to
3e9d16e
Compare
|
@Dimfacion ready for a second round |
|
Chinese is still missing in the default language dropdown |
RomuDeuxfois
force-pushed
the
improvment/i18n-chinese
branch
from
3e9d16e to
f75b947
Compare
Forget this one.. |
No description provided.