Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Import a xls chronogram as a scenario #1229

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

Dimfacion
Copy link
Member

Proposed changes

  • Import an XLS file into a scenario using a previously defined mapper

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 71.12763% with 233 lines in your changes missing coverage. Please review.

Project coverage is 27.78%. Comparing base (a407bc6) to head (ebb633f).

Files Patch % Lines
...rc/main/java/io/openbas/service/InjectService.java 65.44% 145 Missing and 44 partials ⚠️
...main/java/io/openbas/rest/helper/RestBehavior.java 10.00% 9 Missing ⚠️
.../openbas/rest/scenario/response/ImportMessage.java 77.41% 7 Missing ⚠️
...pi/src/main/java/io/openbas/utils/InjectUtils.java 40.00% 3 Missing and 3 partials ⚠️
...io/openbas/rest/exception/FileTooBigException.java 0.00% 4 Missing ⚠️
...rc/main/java/io/openbas/rest/mapper/MapperApi.java 86.66% 2 Missing and 2 partials ⚠️
...rc/main/java/io/openbas/service/MapperService.java 97.59% 0 Missing and 2 partials ⚠️
...openbas/rest/mapper/form/ImportMapperAddInput.java 80.00% 1 Missing ⚠️
...nbas/rest/mapper/form/ImportMapperUpdateInput.java 80.00% 1 Missing ⚠️
...enbas/rest/mapper/form/InjectImporterAddInput.java 80.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1229      +/-   ##
============================================
+ Coverage     24.71%   27.78%   +3.06%     
- Complexity     1062     1249     +187     
============================================
  Files           489      508      +19     
  Lines         12246    12966     +720     
  Branches        666      737      +71     
============================================
+ Hits           3027     3603     +576     
- Misses         9127     9220      +93     
- Partials         92      143      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion marked this pull request as ready for review July 19, 2024 15:01
@Dimfacion Dimfacion merged commit 47af850 into master Jul 22, 2024
7 of 8 checks passed
@Dimfacion Dimfacion deleted the issue/290 branch September 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants