Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Change pagination row per page options #1214

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Jul 15, 2024

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.11%. Comparing base (9e69425) to head (f65c44d).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1214      +/-   ##
============================================
+ Coverage     24.84%   25.11%   +0.26%     
- Complexity     1057     1061       +4     
============================================
  Files           487      487              
  Lines         12121    12121              
  Branches        661      661              
============================================
+ Hits           3012     3044      +32     
+ Misses         9018     8986      -32     
  Partials         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois linked an issue Jul 15, 2024 that may be closed by this pull request
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jul 15, 2024
Copy link
Contributor

@Christian-DONGMO Christian-DONGMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good

@RomuDeuxfois RomuDeuxfois merged commit 92335c5 into master Jul 16, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1167 branch July 16, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pagination doesn't work
2 participants