If Caldera executor is enabled and Caldera is down, the platform should fail to start

[RomuDeuxfois]

Related issues

• If Caldera executor is enabled and Caldera is down, the platform should fail to start #1034

[codecov]

Codecov Report

Attention: Patch coverage is 7.01754% with 53 lines in your changes missing coverage. Please review.

Project coverage is 24.71%. Comparing base (8019106) to head (2e9c8b5).

Files	Patch %	Lines
...cutors/caldera/service/CalderaExecutorService.java	6.89%	27 Missing ⚠️
...va/io/openbas/service/PlatformSettingsService.java	0.00%	21 Missing ⚠️
...enbas/rest/settings/response/PlatformSettings.java	0.00%	4 Missing ⚠️
...njectors/caldera/client/CalderaInjectorClient.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1201      +/-   ##
============================================
- Coverage     24.84%   24.71%   -0.14%     
- Complexity     1057     1062       +5     
============================================
  Files           487      489       +2     
  Lines         12121    12246     +125     
  Branches        661      667       +6     
============================================
+ Hits           3012     3027      +15     
- Misses         9018     9127     +109     
- Partials         91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SamuelHassine]

@RomuDeuxfois do you think this PR is a good occasion to implement also: #1206?

[RomuDeuxfois]

@SamuelHassine we can indeed, the subjects are close.
But to be clear, for caldera the platform does not crash but displays an error message to the user as mentioned on the ticket by JB #1034 (comment).

In the case of mandatory dependencies, we align with OpenCTI, display logs and failed to start.

Is it all good?

[Dimfacion]

@RomuDeuxfois I hate to be that guy but the banner is displayed next to and not above the scrollbar :

It might be worth talking with @jborozco or @Jipegien and see if that's a deal breaker or not.

[Jipegien]

@RomuDeuxfois I hate to be that guy but the banner is displayed next to and not above the scrollbar : It might be worth talking with @jborozco or @Jipegien and see if that's a deal breaker or not.

something to align with what is currently implemented at OpenCTI side.

[RomuDeuxfois]

@RomuDeuxfois I hate to be that guy but the banner is displayed next to and not above the scrollbar : It might be worth talking with @jborozco or @Jipegien and see if that's a deal breaker or not.

You can still scroll without worries

[RomuDeuxfois]

@RomuDeuxfois I hate to be that guy but the banner is displayed next to and not above the scrollbar : It might be worth talking with @jborozco or @Jipegien and see if that's a deal breaker or not.

something to align with what is currently implemented at OpenCTI side.

It's align

[RomuDeuxfois]

@Dimfacion ready for a second round