-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][Backend] duplicate an exercise #1159
Conversation
initial commit
…into issue/1057_Duplicate-an-exercise # Conflicts: # openbas-front/src/admin/components/simulations/ExerciseList.tsx
initial commit
Changing the popover on exercises, atomic testing and scenarios
Creating duplicate dialog
Changing the popover on exercises, atomic testing and scenarios
Implementing duplication on Atomic testing
Implementing duplication on Atomic testing
Changing the popover on exercises
Changing the popover on scenario
Duplicating atomic testing
Duplicating atomic testing
Duplicating exercises and scenarios
Duplicating injects into exercises and scenarios
Duplicating injects into exercises and scenarios
Duplicating exercises and scenarios
…into issue/1057_Duplicate-an-exercise # Conflicts: # openbas-front/src/admin/components/atomic_testings/InjectList.tsx # openbas-front/src/admin/components/scenarios/Scenarios.tsx
Merge with master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing I had 400 errors on duplicate exercises with the following message :
{ "code": 400, "message": "Validation Failed", "errors": { "children": { "exercise_name": { "errors": [ "This value should not be blank." ] } } } }
Duplicate on simulations works but the modal never closes on success.
Duplicate on Injects and Atomic Testing works as expected.
openbas-api/src/main/java/io/openbas/rest/exercise/ExerciseApi.java
Outdated
Show resolved
Hide resolved
correcting tests in error
fixing errors found during code review
fixing errors found during code review
…into issue/1057_Duplicate-an-exercise # Conflicts: # openbas-api/src/main/java/io/openbas/service/AtomicTestingService.java
Merge with master
fixing errors found during code review
fixing errors found during code review
fixing errors found during code review
…into issue/1057_Duplicate-an-exercise # Conflicts: # openbas-api/src/main/java/io/openbas/service/AtomicTestingService.java
fixing errors found during code review
fixing errors found during code review
Correction from demo
Correction from demo
@Christian-DONGMO I still have some bugs
|
…into issue/1057_Duplicate-an-exercise # Conflicts: # openbas-front/src/admin/components/scenarios/Scenarios.tsx
Correction from demo
Correction from demo
…into issue/1057_Duplicate-an-exercise
@Christian-DONGMO I still have one bug
|
Correction from demo
Correction from demo
fixing errors found during code review
Correction from demo
@Christian-DONGMO |
Correction from demo
All bugs have been addressed
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...