Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Validate contracts undefined, null or empty (#1121) #1156

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jun 26, 2024

Proposed changes

  • Validate when contracts maps is null, empty or undefined

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Jun 26, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jun 26, 2024
@savacano28 savacano28 linked an issue Jun 26, 2024 that may be closed by this pull request
@savacano28 savacano28 marked this pull request as ready for review June 26, 2024 09:02
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.17%. Comparing base (6f6f545) to head (0a15268).

Current head 0a15268 differs from pull request most recent head 824abe3

Please upload reports for the commit 824abe3 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1156      +/-   ##
============================================
+ Coverage     25.90%   26.17%   +0.27%     
- Complexity     1062     1066       +4     
============================================
  Files           481      481              
  Lines         11602    11602              
  Branches        609      609              
============================================
+ Hits           3005     3037      +32     
+ Misses         8512     8480      -32     
  Partials         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 changed the title Bug/1121 [backend] Validate contracts undefined, null or empty (#1121) Jun 26, 2024
@savacano28 savacano28 force-pushed the bug/1121 branch 3 times, most recently from 4d4523e to 0baca39 Compare June 27, 2024 13:04
@savacano28 savacano28 merged commit 827af72 into master Jun 28, 2024
1 of 3 checks passed
@savacano28 savacano28 deleted the bug/1121 branch June 28, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the select inject panel can make a scenario page crash
2 participants