Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fixing random login errors #1085

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[backend] Fixing random login errors #1085

merged 2 commits into from
Jun 18, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Jun 15, 2024

Proposed changes

  • Fixing random login errors

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

This needs to be tested extensively ... The fix is to prevent the callback of the SAML Provider to recreate an HttpSession if the previous one is older than 120s.

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 27.03%. Comparing base (ae5f5ce) to head (9802c54).
Report is 15 commits behind head on master.

Files Patch % Lines
...g/OpenBASSaml2AuthenticationRequestRepository.java 16.66% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1085      +/-   ##
============================================
- Coverage     27.06%   27.03%   -0.03%     
- Complexity     1056     1058       +2     
============================================
  Files           468      469       +1     
  Lines         11059    11089      +30     
  Branches        558      561       +3     
============================================
+ Hits           2993     2998       +5     
- Misses         7981     8006      +25     
  Partials         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
@Dimfacion Dimfacion merged commit 89c6076 into master Jun 18, 2024
6 checks passed
johanah29 pushed a commit that referenced this pull request Jun 27, 2024
* [backend] Fixing random login errors
johanah29 pushed a commit that referenced this pull request Jul 16, 2024
* [backend] Fixing random login errors
@Dimfacion Dimfacion deleted the issue/647 branch September 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants