Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Last fix before release #1083

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[frontend] Last fix before release #1083

merged 3 commits into from
Jun 17, 2024

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 commented Jun 14, 2024

Fix

  • Hide the possibility to show timeline
  • Align date display on scenario header based on simulation header
  • Align color button on scenario header based on simulation header
  • Fix simulation start date edition when we switch from scheduled to manual with an error on date
  • Reload simulations page on import

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.99%. Comparing base (e514184) to head (740fe83).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1083      +/-   ##
============================================
- Coverage     27.11%   26.99%   -0.13%     
- Complexity     1048     1068      +20     
============================================
  Files           464      468       +4     
  Lines         10948    11185     +237     
  Branches        547      582      +35     
============================================
+ Hits           2969     3019      +50     
- Misses         7894     8079     +185     
- Partials         85       87       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois changed the title [frontend]Fix in simulation header [frontend] Fix in simulation header Jun 14, 2024
@RomuDeuxfois RomuDeuxfois changed the title [frontend] Fix in simulation header [frontend] Last fix before release Jun 14, 2024
@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review June 14, 2024 20:42
const handleCheckboxChange = (event) => {
setShowTimeline(event.target.checked);
};
// const handleCheckboxChange = (event) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code should be removed :)

/>
<span>{t('Show Timeline')}</span>
</div>
{/* <div style={{ marginRight: 10 }}> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Dimfacion Dimfacion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@RomuDeuxfois RomuDeuxfois merged commit da7baaa into master Jun 17, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the fixbugs branch June 17, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants