Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported scenario keeps the status / scheduling #1050

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Jun 5, 2024

Related issues

Testing

Please, test different export/import with teams, players and variables to validate all workflows.

@RomuDeuxfois RomuDeuxfois linked an issue Jun 5, 2024 that may be closed by this pull request
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 2.35294% with 332 lines in your changes missing coverage. Please review.

Project coverage is 26.48%. Comparing base (120530d) to head (50c92db).
Report is 2 commits behind head on master.

Files Patch % Lines
...main/java/io/openbas/importer/V1_DataImporter.java 0.00% 313 Missing ⚠️
.../main/java/io/openbas/service/ScenarioService.java 0.00% 18 Missing ⚠️
...ain/java/io/openbas/helper/ObjectMapperHelper.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1050      +/-   ##
============================================
+ Coverage     26.17%   26.48%   +0.30%     
- Complexity     1011     1031      +20     
============================================
  Files           451      452       +1     
  Lines         10566    10721     +155     
  Branches        513      525      +12     
============================================
+ Hits           2766     2839      +73     
- Misses         7737     7816      +79     
- Partials         63       66       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Christian-DONGMO
Copy link
Contributor

Nice, Just remember to rebase

@RomuDeuxfois RomuDeuxfois merged commit bc6c0ec into master Jun 10, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/903 branch June 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported scenario keeps the status / scheduling
2 participants