[backend] Change external reference resolution for OpenCTI integration #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
============================================
+ Coverage 25.87% 26.17% +0.30%
- Complexity 1006 1011 +5
============================================
Files 450 451 +1
Lines 10561 10566 +5
Branches 513 513
============================================
+ Hits 2733 2766 +33
+ Misses 7765 7737 -28
Partials 63 63 ☔ View full report in Codecov by Sentry. |
RomuDeuxfois
requested review from
SouadHadjiat,
guillaumejparis and
Dimfacion
and removed request for
SouadHadjiat
RomuDeuxfois
commented
Jun 5, 2024
| @GetMapping(SCENARIO_URI + "/{scenarioId}/exercises") | ||
| @PreAuthorize("isScenarioObserver(#scenarioId)") | ||
| public Iterable<ExerciseSimple> scenarioExercises(@PathVariable @NotBlank final String scenarioId) { | ||
| Scenario scenario = this.scenarioService.scenario(scenarioId); | ||
| return scenario.getExercises().stream().map(ExerciseSimple::fromExercise).toList(); | ||
| } | ||
|
|
||
| // endregion | ||
| @GetMapping(SCENARIO_URI + "/external_reference/{externalReferenceId}") |
There was a problem hiding this comment.
Prefix by /opencti and add versioning (v1)
Keep the old URL with deprecated method
Add swagger doc to explain which endpoint is supported
Release note to be updated with needed OpenCTI version XXX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
OpenCTI should get the latest ended simulation based on scenarios instead of the latest simulation based on the first scenario.
Related issues
Testing
OpenCTI PR -> OpenCTI-Platform/opencti#7233