Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injects that have been removed are still visible in the timeline #2294

Closed
EllynBsc opened this issue Jan 24, 2025 · 6 comments · Fixed by #2329
Closed

Injects that have been removed are still visible in the timeline #2294

EllynBsc opened this issue Jan 24, 2025 · 6 comments · Fixed by #2329
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved

Comments

@EllynBsc
Copy link
Member

EllynBsc commented Jan 24, 2025

Description

In a simulation two injects that have been removed but are still visible in the timeline, even though they don't appear in the stimuli tab.

Environment

1.11.3

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Create a simulation with injects
  2. Check the timeline
  3. Remove 1 or 2 injects in this simulation
    4.Check the timeline

Expected Output

The 2 deleted injects should not be visible anymore

Actual Output

The injects are still visible in the timeline

Image
Image

@EllynBsc EllynBsc added the bug use for describing something not working as expected label Jan 24, 2025
@EllynBsc EllynBsc modified the milestone: Bugs backlog Jan 24, 2025
@savacano28 savacano28 self-assigned this Jan 28, 2025
@RomuDeuxfois
Copy link
Member

Should be merged on master branch

@savacano28
Copy link
Contributor

savacano28 commented Jan 29, 2025

@EllynBsc
For the deleted injects: I can't reproduce it in master : simulation or in release: simulation

For the disabled injects: I'll make the changes

@savacano28
Copy link
Contributor

@EllynBsc @RomuDeuxfois I made a small fix for another bug that helps with this bug in the current release, maybe we can better include this bug in the current release 1.12.0?

@RomuDeuxfois
Copy link
Member

@savacano28 good point !
@EllynBsc or @jborozco can we push this fix on the master or not ?

@EllynBsc
Copy link
Member Author

yes good point, I'm ok with it 👍 🟢

@RomuDeuxfois
Copy link
Member

@guillaumejparis will do the cherry pick if it's ok for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
3 participants