Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI inconsistency: space separators in simulation list + height of the lines #1452

Closed
SamuelHassine opened this issue Sep 16, 2024 · 2 comments · Fixed by #1479
Closed

UI inconsistency: space separators in simulation list + height of the lines #1452

SamuelHassine opened this issue Sep 16, 2024 · 2 comments · Fixed by #1479
Assignees
@johanah29
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone
Release 1.7.0

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Sep 16, 2024 •
edited
Loading

Description

Simulation list separator issue:

image

Same issue as #1400, but in simulations.... Please check other lists!

Also, lines have not the same height across the application:

Atomic testing (height 50):

image

Scenarios (height 45):

image

=> We should align with OpenCTI: height should be 50 everywhere.
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Sep 16, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Sep 17, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Sep 17, 2024
@EllynBsc EllynBsc added the tiny use to identify tiny feature to develop or bug to fix (< a week to solve) label Sep 17, 2024
@jborozco
Copy link

Hi Sam, these inconsistency will be fixed once we will introduce the unified data table from the design system, do you want to address this issues right now with quick fixes ? Personally, I would advise to wait to avoid wasting time on this.

@jborozco jborozco added the needs more info use to identify issue needing additional info to be triaged or solved label Sep 17, 2024
@SamuelHassine
Copy link
Member Author

@jborozco Can you please prioritize the new data table introduction?

@jborozco jborozco removed the tiny use to identify tiny feature to develop or bug to fix (< a week to solve) label Sep 18, 2024
@johanah29 johanah29 self-assigned this Sep 18, 2024
@johanah29 johanah29 mentioned this issue Sep 19, 2024
Merged
@johanah29 johanah29 linked a pull request Sep 19, 2024 that will close this issue
[frontend] Fix abnormal space and height in lists #1479
Merged
johanah29 added a commit that referenced this issue Sep 20, 2024
@johanah29
[frontend] Fix abnormal space and height in lists (#1452)
29ec77a
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Sep 20, 2024
@EllynBsc EllynBsc removed the needs more info use to identify issue needing additional info to be triaged or solved label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanah29 johanah29

Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Milestone
Release 1.7.0
Development

Successfully merging a pull request may close this issue.

[frontend] Fix abnormal space and height in lists OpenBAS-Platform/openbas
5 participants
@SamuelHassine @EllynBsc @jborozco @johanah29 @RomuDeuxfois