-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After deleting a payload, atomic testing is throwing an error when accessing #1141
Comments
The error message should say: "This payload has been deleted." |
@jborozco I fixed the crash, but I have some questions... when a payload is deleted, what happens in the following scenarios :
|
I don't know how this fix has passed the review @RomuDeuxfois @Dimfacion. First test: going to an atomic testing with a deleted payload, then clicking on configure: Drawer is empty. Button should be disabled, and the screen should reflect the fact that the payload is not present anymore and this atomic testing cannot be replayed again. To be refined with @jborozco . |
@SamuelHassine @jborozco Sure, I pointed out the concerns initially, but the main issue was a crashing page. I thought fixing that was priority number one, and these enhancements could be another ticket also? |
@SamuelHassine, Like @savacano28 pointed out, she told me about the issue. We thought it was more urgent to fix something crashing even if it meant having a temporary degraded version of the page. Sorry for not communicating enough on this call. Please, reach out if you feel we should handle the issue differently in the future. |
When a payload is deleted then the contract is deleted. Results:
|
Exporting a scenario or a simulation with a deleted inject, then importing it -> INTERNAL ERROR |
Description
Click on one of the list that is noted "deleted".
The text was updated successfully, but these errors were encountered: