Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After deleting a payload, atomic testing is throwing an error when accessing #1141

Closed
SamuelHassine opened this issue Jun 21, 2024 · 7 comments · Fixed by #1160 or #1193
Closed

After deleting a payload, atomic testing is throwing an error when accessing #1141

SamuelHassine opened this issue Jun 21, 2024 · 7 comments · Fixed by #1160 or #1193
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone

Comments

@SamuelHassine
Copy link
Member

Description

image

Click on one of the list that is noted "deleted".

@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jun 21, 2024
@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label Jun 24, 2024
@jborozco jborozco added this to the Bugs backlog milestone Jun 24, 2024
@savacano28 savacano28 self-assigned this Jun 24, 2024
@jborozco
Copy link

The error message should say: "This payload has been deleted."

@savacano28
Copy link
Contributor

savacano28 commented Jun 26, 2024

@jborozco I fixed the crash, but I have some questions... when a payload is deleted, what happens in the following scenarios :

  • If an atomic testing has just this single inject, we should still allow updates to be made? (or hide button update and configure?)

Image

Image

Image

  • On the injects page for exercises, should we remove this inject from the list, or should we continue to display it?

Image

  • timeline

Image

@SamuelHassine
Copy link
Member Author

SamuelHassine commented Jul 1, 2024

I don't know how this fix has passed the review @RomuDeuxfois @Dimfacion.

First test: going to an atomic testing with a deleted payload, then clicking on configure:

image

Drawer is empty. Button should be disabled, and the screen should reflect the fact that the payload is not present anymore and this atomic testing cannot be replayed again. To be refined with @jborozco .

@savacano28
Copy link
Contributor

@SamuelHassine @jborozco Sure, I pointed out the concerns initially, but the main issue was a crashing page. I thought fixing that was priority number one, and these enhancements could be another ticket also?

@Dimfacion
Copy link
Member

Dimfacion commented Jul 2, 2024

@SamuelHassine, Like @savacano28 pointed out, she told me about the issue. We thought it was more urgent to fix something crashing even if it meant having a temporary degraded version of the page. Sorry for not communicating enough on this call. Please, reach out if you feel we should handle the issue differently in the future.

@RomuDeuxfois
Copy link
Member

When a payload is deleted then the contract is deleted.

Results:

  • If an atomic testing is created on this payload, then we keep the previous result but we can only delete this atomic testing
  • If a scenario is created with an inject based on this payload
    • this inject will have the type deleted
    • this inject will be exported
  • If a scenario is duplicated with an inject based on this payload
    • this inject will be duplicate
  • If a simulation is created from a scenario with an inject based on this payload
    • this inject will be created
  • If a simulation is created with an inject based on this payload
    • this inject will have the type deleted
    • this inject will be exported
    • this inject wont appear in the timeline
  • If a simulation is duplicated with an inject based on this payload
    • this inject will be duplicate

@RomuDeuxfois RomuDeuxfois removed this from the Release 1.3.0 milestone Jul 25, 2024
@RomuDeuxfois RomuDeuxfois added this to the Release 1.4.0 milestone Jul 25, 2024
@RomuDeuxfois
Copy link
Member

Exporting a scenario or a simulation with a deleted inject, then importing it -> INTERNAL ERROR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
5 participants