feat: add Rename Command #2453
Closed
feat: add Rename Command #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mission judgment after the default user is connected (#2449)
added 2 commits
March 6, 2024 11:22
luky116
reviewed
Mar 6, 2024
| @@ -50,7 +50,7 @@ class BaseConf { | |||
| bool GetConfIntHuman(const std::string& name, int* value) const; | |||
| bool GetConfInt64(const std::string& name, int64_t* value) const; | |||
| bool GetConfInt64Human(const std::string& name, int64_t* value) const; | |||
|
|
|||
| bool GetConfStr(const std::string& name, std::vector<std::string>* values) const; | |||
There was a problem hiding this comment.
这里直接使用 GetConfStrMulti 方法，直接获取一个数组
| @@ -178,6 +178,19 @@ bool BaseConf::GetConfStr(const std::string& name, std::string* val) const { | |||
| return false; | |||
| } | |||
|
|
|||
| bool BaseConf::GetConfStr(const std::string& name, std::vector<std::string>* values) const { | |||
| @@ -50,6 +50,14 @@ void PikaCmdTableManager::InitCmdTable(void) { | |||
| } | |||
| } | |||
|
|
|||
| void PikaCmdTableManager::RenameCommand(const std::string before, const std::string after) { | |||
There was a problem hiding this comment.
考虑 after 为 "" 的情况，比如在 conf 文件里面配置的 hget：
rename-command : hget
rename-command : set 360set
redis 里面会先把命令删除了：https://github.com/redis/redis/blob/unstable/src/config.c
另外，如果 before cmd 不存在，直接返回错误，让用户去修改配置文件
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2452