Removed a redundant check of ttl in setcmd #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(when exec cmd like "set k v ex/px 10", non-negetive check of ttl will be done in function "RedisStrings::Setex", no need of doing it in "SetCmd::DoInitial"). 2.removed an unnecessary dynamic cast.
chejinge
approved these changes
May 20, 2023
AlexStocks
approved these changes
May 25, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
(when exec cmd like "set k v ex/px 10", non-negetive check of ttl will be done in function "RedisStrings::Setex", no need of doing it in "SetCmd::DoInitial"). 2.removed an unnecessary dynamic cast. Co-authored-by: cjh <[email protected]>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
(when exec cmd like "set k v ex/px 10", non-negetive check of ttl will be done in function "RedisStrings::Setex", no need of doing it in "SetCmd::DoInitial"). 2.removed an unnecessary dynamic cast. Co-authored-by: cjh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
（这个pr前面不小心被我操作分支的时候删了，现在再提一下）
1.执行set key value ex/px sec/ms 命令时，会对ttl进行两次非负检查：
第一次：setcmd的Doinitial函数中，如果set命令带了ex/px则会判断ttl是否非负
第二次：在带有ex/px执行set时，setcmd的Do方法最后是调用partition->db()->Setex方法，在这个方法内部会进行ttl非负检查：
为什么选择移除Doinitial中的非负检查，而不是移除setex函数中的：因为像"setex key seconds value"这样的命令在Doinitial中没有做ttl的非负检查（依赖于Setex方法中的ttl非负检查）
2.在一个被高频执行的函数中（Docmd函数），疑似存在不必要的动态类型转换（先把父类指针转子类传递给SetConn方法，但是SetConn的形参是父类指针的类型，所以又会隐式转换回去，平白多了2次没有意义的转换？）
当然，上面第2点只是我个人的看法，只是我个人没有看出这个转换有别的用处，如有错误，还请指正。