Add support for Boolean in R client generator #9469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Ramanth @saigiridhar21 et al,
as mentioned in the branch name, this PR is in response to (my) #9468 . Unfortunately I am not a openapi-generator hacker, so I have no idea if this is what's required, and its a best-effort approach. What I did:
model.mustache
in two places to check for the correct class, and I did that in analogy to the lines before/after my insertionmodel.mustache
in two places further down, where numbers are printed with%d%
and everything else was printed as"%s"
. The latter needed changing. I HOPE what I did results in unchanged"%s"
for everything but Boolean, and%s
for booleansself$
{{baseName}}by
tolower()` in case of booleans.The second commit adds the petstore, changed only where the logical
complete
is involved.And apparently my editor removed an empty line at the end of the template, so some changes remove only whitespace
I do not know exactly how else I can test everything. Hope that helped nevertheless,
Yours,
Steffen
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x