[csharp][httpclient] Introduce FileParameter as an abstraction #9426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new class FileParameter as an abstraction to use in our ApiClients. It contains an automatic implicit conversion for existing stream parameters so its backwards compatible to existing code.
The reason for this is, that there are platforms that have file like parameters and we currently have no way to pass a filename into our api clients aside from FileStreams. However for Browser platforms there are no FileStreams there are IBrowserFiles that do not map. So we need another abstraction.
This could be further expanded to add content types to the files.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)