-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript-angular: Angular 10 support #7037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@macjohnny thanks for taking a look at it. I ran
locally and committed the changes but this does not seem to help |
Maybe the scripts need to be run on a unix system |
I presume he ran it in Git bash, which shouldn't differ from unix? |
I ran it on my Mac and in a Ubuntu docker container as well. Both resulted in no changes |
Looking at e.g. https://github.com/patst/openapi-generator/blob/b860af74ce31c00f5fb35283b2526efc4100423d/samples/client/petstore/typescript-angular-v7-not-provided-in-root/builds/default/.openapi-generator/FILES the /./ seems to be present, too. I don‘t know why this happens, but you could also just edit the files manually and commit them to have the CI pass |
@patst thanks for your contribution |
Fixes #7036
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)