Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] ruby client build from hash nullable #6945

Conversation

tsuwatch
Copy link
Contributor

@tsuwatch tsuwatch commented Jul 15, 2020

ref: #4391 #6780

Foo:
  type: object
  properties:
    x:
      type: integer
      nullable: true

On current master:

p OpenapiClient::Foo.new({ x: nil }).to_hash #=> {:x=>nil}
p OpenapiClient::Foo.build_from_hash({ x: nil }).to_hash #=> {}

On this branch:

p OpenapiClient::Foo.build_from_hash({ x: nil }).to_hash #=> {:x=>nil}

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@cliffano @zlx @autopp please review

@tsuwatch tsuwatch changed the title ruby client build from hash nullable [Ruby] ruby client build from hash nullable Jul 15, 2020
@tsuwatch tsuwatch force-pushed the feature/ruby-client-build-from-hash-nullable branch from adc0175 to 2d3c1eb Compare July 15, 2020 05:46
@tsuwatch tsuwatch force-pushed the feature/ruby-client-build-from-hash-nullable branch from 2d3c1eb to 0eabaff Compare July 15, 2020 08:20
@tsuwatch tsuwatch force-pushed the feature/ruby-client-build-from-hash-nullable branch from 0eabaff to 5e97036 Compare July 15, 2020 09:51
@tsuwatch
Copy link
Contributor Author

@cliffano @zlx @autopp could you review this if you get a chance?

@autopp
Copy link
Contributor

autopp commented Jul 16, 2020

@tsuwatch Thanks for PR. I'll review it.

Copy link
Contributor

@autopp autopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsuwatch LGTM 👍

@autopp autopp merged commit 9318833 into OpenAPITools:master Jul 16, 2020
@tsuwatch tsuwatch deleted the feature/ruby-client-build-from-hash-nullable branch July 17, 2020 01:54
@tsuwatch
Copy link
Contributor Author

@autopp Thakn you!

@wing328 wing328 added this to the 5.0.0 milestone Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants