Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][jersey2-client] Disable coercion of scalars #6811

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jun 29, 2020

I have a schema that has a oneOf with two choices, one is an alias for string and the other for int:

components:
  schemas:
    Something:
      type: object
      oneOf:
        - $ref: '#/components/schemas/One'
        - $ref: '#/components/schemas/Two'
    One:
      type: string
    Two:
      type: integer

The problem is that when the API returns a string that has integer in it, e.g. "1234", the Jackson library (which has coercion of scalars turned on by default) fails to deserialize the Something object, as "1234" deserializes successfully as both Integer and String. This PR disables scalar coercion to prevent this, thus making the above example work. (As an additional note, I think we want to have this feature disabled since it is something that other clients don't do)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@bkabrda
Copy link
Contributor Author

bkabrda commented Jun 30, 2020

Hmm, actually there needs to be more work done in order for this setting to be respected inside the custom deserializers for oneOf. I'll add a another commit doing that.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test results look good.

@wing328 wing328 merged commit 03e8aee into OpenAPITools:master Jul 23, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants