Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for operation defination containing ref schema #6676

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

ngp-star
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

fix for the issue #6484
PR is against the master branch.

@ngp-star
Copy link
Contributor Author

@wing328
is there any updates on this PR?

@wing328
Copy link
Member

wing328 commented Jun 21, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Jun 21, 2020

cc @OpenAPITools/generator-core-team

@ngp-star
Copy link
Contributor Author

@wing328
yeah sure can you please guide on this? so that my commit will be linked to my git hub account.

@ngp-star
Copy link
Contributor Author

@wing328
I have modified the email address for this particular commit by following the link Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account . what you shared.

previously my email was :

Author: ngp-star [email protected]

now it's changed to Author: ngp-star [email protected]

now it should be fine I think, can you please confirm?

@ngp-star
Copy link
Contributor Author

@wing328
are there any updates on this?

@ngp-star
Copy link
Contributor Author

@wing328
is there any update on this PR?

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 6a61910 into OpenAPITools:master Jun 29, 2020
@wing328
Copy link
Member

wing328 commented Jun 29, 2020

@ngp-star thanks for the PR, which has been merged into master.

@ngp-star
Copy link
Contributor Author

@ngp-star thanks for the PR, which has been merged into master.

@wing328
you are welcome

@ngp-star
Copy link
Contributor Author

@wing328
is it possible to see my name in contributors link what you shared?.https://github.com/OpenAPITools/openapi-generator/graphs/contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants