Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go-experimental] Fix error message when unmarshaling wrong enum value #6663

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Jun 15, 2020

The error message uses the unmarshaled struct, but it is empty since the unmarshal failed. This fixes it to have a proper error message.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@zippolyte
Copy link
Contributor Author

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@wing328
Copy link
Member

wing328 commented Jun 15, 2020

CircleCI failure already fixed in the master.

@wing328 wing328 merged commit 2460cfc into OpenAPITools:master Jun 15, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jun 15, 2020
@zippolyte zippolyte deleted the hippo/ume branch June 15, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants