Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic bearer authentication to objc template #6640

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

onlymate
Copy link
Contributor

Referred to the OpenAPI Spec https://swagger.io/docs/specification/authentication/bearer-authentication/ it is able to add bearer authentication to OpenAPI.
The Basic Bearer was ignored in OBJC Template.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 5.0.0 milestone Jun 12, 2020
@wing328 wing328 changed the title added basic bearer authentication to objc template Added basic bearer authentication to objc template Jun 12, 2020
@wing328
Copy link
Member

wing328 commented Jun 12, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@onlymate onlymate force-pushed the fix-objc-bearer-template branch from 429bde8 to bd7e064 Compare June 12, 2020 10:54
@onlymate onlymate force-pushed the fix-objc-bearer-template branch from bd7e064 to f17a633 Compare June 12, 2020 11:02
@onlymate
Copy link
Contributor Author

@wing328 Thanks! I updated it.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll update the samples in a separate commit.

@wing328 wing328 merged commit a0f2293 into OpenAPITools:master Jun 12, 2020
@onlymate onlymate deleted the fix-objc-bearer-template branch July 22, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants