Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core, Rust Server] Support optional headers #6575

Merged
merged 4 commits into from
Jun 15, 2020
Merged

[Core, Rust Server] Support optional headers #6575

merged 4 commits into from
Jun 15, 2020

Conversation

richardwhiuk
Copy link
Contributor

Rust Server currently treats all headers declared in the OpenAPI file as mandatory, when actually they default to optional.

Furthermore, the core code doesn't pass through whether a header is mandatory or optional.

This makes a small change to the DefaultCodgen to pass this data through, defaulting correctly.

The Rust change is then fairly straightforward - we enhance Rust Server, using Option to represent non-required headers.

This is breaking, because we'll treat headers which were treated as required before as optional, and we'll provide them as an Option instead.

Rust Server Technical Committee

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@richardwhiuk
Copy link
Contributor Author

@OpenAPITools/generator-core-team - Minor core change as part of this.

@richardwhiuk richardwhiuk merged commit 3ba787c into OpenAPITools:master Jun 15, 2020
@richardwhiuk richardwhiuk deleted the rust-server-optional-headers branch June 15, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant