Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use supplied packageName instead of hardcoded #6561

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Use supplied packageName instead of hardcoded #6561

merged 1 commit into from
Jun 15, 2020

Conversation

Katur7
Copy link
Contributor

@Katur7 Katur7 commented Jun 5, 2020

Hardcoding open_api_utils there breaks this package if packageName option is used for generating the server code.
Use the provided {{packageName}} template variable the same as it is used in the rest of the file.
The samples do not change when using the default packageName.

CC erlang technical committe
@tsloughter @jfacorro @robertoaloi

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Hardcoding open_api_utils there breaks this package if packageName option is used for generating the server code
@Katur7 Katur7 marked this pull request as ready for review June 5, 2020 15:16
@wing328
Copy link
Member

wing328 commented Jun 5, 2020

@Katur7 thanks for the PR, which looks good to me. I'll merge over the weekend if no one has further questions/feedback.

@Katur7
Copy link
Contributor Author

Katur7 commented Jun 9, 2020

Sounds good :)

@Katur7
Copy link
Contributor Author

Katur7 commented Jun 11, 2020

@wing328, Hi, is there anything I can do to help getting this merged?

@wing328 wing328 merged commit 982491e into OpenAPITools:master Jun 15, 2020
@wing328
Copy link
Member

wing328 commented Jun 15, 2020

@Katur7 nope, just merged. Sorry for the delay. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants