Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][jersey2] Add null type support to oneOf/anyOf #6269

Merged
merged 2 commits into from
May 12, 2020
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 12, 2020

  • Add null type support to oneOf/anyOf
  • tested locally with a spec using oneOf and "type: null"

To fix #6257

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328
Copy link
Member Author

wing328 commented May 12, 2020

Tested with https://raw.githubusercontent.com/CiscoM31/intersight-openapi/master/intersight-openapi-v3.yaml and the code compiles without issues.

@wing328 wing328 merged commit f8be392 into master May 12, 2020
@wing328 wing328 deleted the java-one-of-null branch May 12, 2020 16:46
@wing328 wing328 added this to the 5.0.0 milestone Jul 3, 2020
@4brunu 4brunu mentioned this pull request Feb 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Java][jersey2] null type is not supported in oneOf/anyOf
1 participant