Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c-sharp] generator added CancellationToken to async api calls #6243

Merged
merged 2 commits into from
May 11, 2020
Merged

[c-sharp] generator added CancellationToken to async api calls #6243

merged 2 commits into from
May 11, 2020

Conversation

kilimnik
Copy link
Contributor

@kilimnik kilimnik commented May 10, 2020

I added an optional CancellationToken to the asynchronous ApiClient and DefaultApiClient methods so it is possible to cancel them while they are running.
This resolves #4905 which asks for an overload but I think that an optional attribute is much cleaner.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@mandrean (2017/08), @jimschubert (2017/09) ❤️ @frankyjuang (2019/09) @shibayan (2020/02)

@kilimnik kilimnik closed this May 10, 2020
@kilimnik kilimnik reopened this May 10, 2020
Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimschubert jimschubert added this to the 5.0.0 milestone May 10, 2020
@jimschubert
Copy link
Member

Thanks for the contribution! This looks good to me. Although I haven't tested locally, it hits all points:

  • uses default(Type)
  • handles preceding comma in args list for cases with no parameters
  • includes the import
  • regenerates samples

Will merge when CI runs complete.

@jimschubert jimschubert self-assigned this May 10, 2020
@jimschubert jimschubert merged commit 5693cb9 into OpenAPITools:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [C#] Add a CancellationToken to overloads
2 participants