Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Added a check to make sure an argument is passed #6207

Merged
merged 2 commits into from
May 8, 2020

Conversation

digininja
Copy link
Contributor

PR to go with issue #6206 to stop unbound variable errors when running docker-entrypoint.sh without an argument.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@digininja
Copy link
Contributor Author

Yes, I can add that.

@digininja
Copy link
Contributor Author

I've done that, and just for OCD value, put the commands into alphabetical order.

My only worry with the change I've made is that the final else on the original if passes through any commands the script doesn't know about to exec. Should this be able to be reached without an argument? If it should, then my update will break that functionality as I exit early if no command is passed. If this has to have at least one argument, then my change is OK.

@wing328
Copy link
Member

wing328 commented May 8, 2020

I think we can go with what you've right now and submit PRs later if there are feedbacks from other users on the usage.

@wing328 wing328 changed the title added a check to make sure an argument is passed [Docker] Added a check to make sure an argument is passed May 8, 2020
@wing328 wing328 merged commit 6e619e0 into OpenAPITools:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants