Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hb] Honor supporting files when applying bundles #5364

Merged

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Feb 19, 2020

Experimental handlebars template engine wasn't applying data bundle to supporting files. This fixes that.

Because this changes how default mustache supporting files are handled, and our samples directory overwrites existing files, I'd like someone to double-check generation of mustache. I'd deleted the whole samples directory before regeneration, but this results in ~1200 lines of git status. I switched over to master and had the same results

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

closes #5320

@jimschubert jimschubert added the Bleeding Edge Experimental features (e.g. non-standard spec, "futures", or IETF draft) label Feb 21, 2020
@jimschubert jimschubert merged commit ef00854 into OpenAPITools:master Feb 23, 2020
@jimschubert jimschubert deleted the handlebars-supporting-files branch February 23, 2020 21:59
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
…ls#5364)

* [handlebars] Honor supporting files when applying bundles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bleeding Edge Experimental features (e.g. non-standard spec, "futures", or IETF draft) Enhancement: General Issue: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Handlebars template engine doesn't generate SupportingFiles properly
1 participant