Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-libcurl] Guard memory free for query parameters to avoid coredump #5356

Merged
merged 2 commits into from
Feb 18, 2020
Merged

[C-libcurl] Guard memory free for query parameters to avoid coredump #5356

merged 2 commits into from
Feb 18, 2020

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Feb 18, 2020

After generating a C-libcurl client for kubernetes and linking with my program, a coredump will happen due to deleting an un-allocated memory

Program received signal SIGSEGV, Segmentation fault.
__GI___libc_free (mem=0x3000000030) at malloc.c:2951
2951    malloc.c: No such file or directory.
(gdb) bt
#0  __GI___libc_free (mem=0x3000000030) at malloc.c:2951
#1  0x00000000004290a0 in CoreV1API_listCoreV1NamespacedSecret (apiClient=0x6b4570, namespace=0x488489 "default", 
    pretty=0x0, allowWatchBookmarks=0, _continue=0x0, fieldSelector=0x0, labelSelector=0x0, limit=0, 
    resourceVersion=0x0, timeoutSeconds=1000, watch=0) at /root/c_k8s_api_client/api/CoreV1API.c:16598
#2  0x0000000000401532 in listSecret () at main.c:77
#3  0x000000000040179f in main (argc=2, argv=0x7fffffffe0a8) at main.c:159

The coredump happens at:

    free(keyQuery_pretty);

But actually, keyQuery_pretty is not allocated.

So I added some guards for the query parameters before memory free.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the master: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant

@wing328 wing328 merged commit f9a040d into OpenAPITools:master Feb 18, 2020
@wing328 wing328 added this to the 4.3.0 milestone Feb 18, 2020
@ityuhui ityuhui deleted the yhworking branch February 29, 2020 07:37
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
…penAPITools#5356)

* [C-libcurl] Guard memory free for query parameters to avoid coredump

* [C-libcurl] Guard memory free for query parameters to avoid coredump (2nd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants