Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Python HTTP signature update #5154

Merged
merged 11 commits into from
Feb 3, 2020

Conversation

sebastien-rosset
Copy link
Contributor

@sebastien-rosset sebastien-rosset commented Jan 29, 2020

This PR is a follow up to the initial commit for HTTP signature support, based on additional testing and review.

  • The OAuth2 "access_token" value should be null by default, not empty string. Otherwise, the client will attempt to set the "Authorization" header with an empty bearer token.
  • Added more documentation.
  • Conditionally generate the examples in the Configuration() object, based on what security schemes are defined in the OAS spec.
  • In the Configuration examples, add snippet of OAS spec with a security scheme to better explain the use cases.
  • Add missing import
  • Fix typo

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sebastien-rosset

This comment has been minimized.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @sebastien-rosset! This looks good.

@spacether spacether merged commit 67e4cc8 into OpenAPITools:master Feb 3, 2020
@sebastien-rosset sebastien-rosset deleted the python-http-signature-2 branch May 23, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants