Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] [Qt5] Support abort operation #5114

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

etherealjoy
Copy link
Contributor

Add a method to abort operations after they have been invoked.

Fixes #3065

cc
@stkrwork @ravinikam @muttleyxd @MartinDelille

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Copy link
Contributor

@MartinDelille MartinDelille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@etherealjoy
Copy link
Contributor Author

Many thanks for the review.

@etherealjoy etherealjoy added this to the 4.2.3 milestone Jan 27, 2020
@etherealjoy etherealjoy merged commit ab5f224 into OpenAPITools:master Jan 27, 2020
@etherealjoy etherealjoy deleted the add_abort_method branch June 17, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][Qt5] Manually abort a request
3 participants